Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: makes closets/lockers better #257

Merged
merged 1 commit into from
May 13, 2024
Merged

Mirror: makes closets/lockers better #257

merged 1 commit into from
May 13, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #24942: makes closets/lockers better from space-wizards space-wizards/space-station-14

e94fba5f702820588ad358a1824d67920fd399f8

PR opened by potato1234x at 2024-02-04 09:07:17 UTC

PR changed 9 files with 121 additions and 0 deletions.

The PR had the following labels:

  • No C#
  • Changes: Sprites

Original Body

About the PR

Makes wall lockers craftable
Makes secure lockers craftable
Makes secure lockers deconstructible

Why / Balance

every time i try to deconstruct a wall with a wall locker on it or need to remove a secure locker i have to beat it to death for 5 minutes. and added the crafting recipes for consistency and more building opportunities

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑

  • add: Added crafting recipes for wall lockers and secure lockers
  • fix: Fixed secure lockers and wall lockers not being deconstructible

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

RSI Diff Bot; head commit 9f9b87a merging into 3bf08c7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Storage/closet.rsi

State Old New Status
secure_icon Added

Resources/Textures/Structures/Storage/wall_locker.rsi

State Old New Status
generic_icon Added

DangerRevolution
DangerRevolution suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be checked for Delta lockers

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 04:09
@DangerRevolution DangerRevolution enabled auto-merge (squash) May 13, 2024 13:55
@DangerRevolution DangerRevolution merged commit 2e226b3 into Simple-Station:master May 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DangerRevolution DangerRevolution DangerRevolution approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimpleStation14 @VMSolidus @DangerRevolution